[fix #321] Fixes the crash when the user opens the app while offline#322
Open
alialamine wants to merge 1 commit intofullstackreact:masterfrom
Open
[fix #321] Fixes the crash when the user opens the app while offline#322alialamine wants to merge 1 commit intofullstackreact:masterfrom
alialamine wants to merge 1 commit intofullstackreact:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug happens because firebase tries to login 3 times if the user is offline. Because of this the callback will be called several times (2 times more than it should).
This will catch the exception from it so that the callback doesn't crash if this happens (just show the error)